代码优化

src/main/java/cn/zingfin/base/BaseOpenApiRequest.java

@@ -3,9 +3,8 @@ package cn.zingfin.base;
 import lombok.Data;
 
 /**
- * @author chsm
- * @version v1.0
- * @since 2020/8/10 16:24
+ * @author jwc
+ * @date 2020/9/2 16:24
  */
 @Data
 public class BaseOpenApiRequest {

src/main/java/cn/zingfin/config/SpringControllerAdvice.java

@@ -28,16 +28,17 @@ import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Set;
 
 /**
  * Title: SpringControllerAdvice
  * <p>
- * Description:
+ * Description: 处理全局异常
  *
- * @author 瞿宇龙
+ * @author  jiwancheng
  * @version V1.0
- * @since 2019/8/19
+ * @since 2020/9/2
  */
 @ControllerAdvice
 @Slf4j
@@ -48,7 +49,6 @@ public class SpringControllerAdvice {
     @Resource
     private OpenApiPlatformKey openApiPlatformKey;
 
-
     /**
      * 处理所有接口数据验证异常
      *
@@ -79,22 +79,6 @@ public class SpringControllerAdvice {
                 .withMsg(e.getMessage()).withSuccess(false).build(), response);
     }
 
-    /**
-     * 业务异常统一处理
-     *
-     * @param e
-     * @return
-     */
-    @ExceptionHandler(BizException.class)
-    @ResponseBody
-    ResultMsg bizException(BizException e) {
-        error(e);
-        return ResultMsg.builder()
-                .withErrorCode(e.getCode() == null ? SystemErrorCodeEnum.SYSTEM_ERROR.getCode() : e.getCode())
-                .withMsg(e.getMessage()).withSuccess(false).build();
-    }
-
-
     @ExceptionHandler(Exception.class)
     @ResponseBody
     ResultMsg exception(Exception e) {
@@ -104,9 +88,9 @@ public class SpringControllerAdvice {
     }
 
     private void error(Exception e) {
-        HttpServletRequest request = ((ServletRequestAttributes) RequestContextHolder.getRequestAttributes()).getRequest();
-        String requestURI = request.getRequestURI();
-        log.error("{}请求出错，{}", requestURI, e.getMessage(), e);
+        HttpServletRequest request = ((ServletRequestAttributes) Objects.requireNonNull(RequestContextHolder.getRequestAttributes())).getRequest();
+        String requestUrl = request.getRequestURI();
+        log.error("{}请求出错，{}", requestUrl, e.getMessage(), e);
     }
 
 

src/main/java/cn/zingfin/domain/service/impl/VerificationServiceImpl.java

@@ -2,7 +2,6 @@ package cn.zingfin.domain.service.impl;
 
 import cn.zingfin.common.enums.OpenApiErrorCodeEnums;
 import cn.zingfin.common.util.HttpUtil;
-import cn.zingfin.common.util.HttpUtils;
 import cn.zingfin.domain.model.CompanyInfoModel;
 import cn.zingfin.domain.model.PersonalMobileInfoModel;
 import cn.zingfin.domain.service.VerificationService;
@@ -12,8 +11,6 @@ import cn.zingfin.web.model.VerificationMobileRequest;
 import cn.zingfin.web.model.VerificationPersonalRequest;
 import com.alibaba.fastjson.JSONObject;
 import lombok.extern.slf4j.Slf4j;
-import org.apache.http.HttpResponse;
-import org.apache.http.util.EntityUtils;
 import org.springframework.stereotype.Service;
 
 import java.io.IOException;

src/test/java/ocr/OcrIdCardTest.java

@@ -14,7 +14,7 @@ public class OcrIdCardTest {
         // 对方的私钥
         String appPrivateKey = "MIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQCm6xO5wJGSRvtEVvCaAPxRwOuc7RH4nT79KIXFzwRdjeBzIR78m/bSMv7hokmahTNiF7veI/8WD8EAz7E6VoXGatzbtGOVO3GEkd8hssAOw6t3dCfr5PNStS4qyjK0haEiya3LlKYowuFv5RLwmJYAqRHlCW73ala+mk3iDBYHfuLqAKhFn+zCE3kQQD7AWwkxWhf4IckQ6ymhPjsX/5pjJXfzNjhbf1pryugl23HNm4KQ+pEPDLvQ2vziOVEl6/6y7zKIf4pr/e9jq8T3ZX7T+AExunDAsToEqZP2ybdek9dJOHfJtobFZoFW6/2XTd2vHTBFUDoUbezS63Q1FAflAgMBAAECggEAcZH6/uT+ZyeyqOH6nN5Uz49TAJfxJVZgWEGtG1TqpHj3IX6Epd28h3K5J26TY/aDape5dMDLPAiGCnZGIOpj5Qgqs7Y+F3i1mTzjM/t6X9FUplc7Hm7N/BVYjza6X0eYxqGwhZbjo1JNryOOynMXhOWETnEntmH9GXzFxyrwBjJ4skUDK78I8vDmazj0hVj7VULWjhH0ufG17mDme7mVjJh1oOpCqEVoCqkMRHWsZg8o0bwYOczxoQG+T9vdR7K9GyLdFctFUGZNlZPsyDVcPrsC4IP+a8630YMxI06DBS/r8xTqS3Dh2YWcuNB0TQsUDg/nms+y+tT9fwFk1rX+9QKBgQD/eqFa+t+RLAkUbAvwLtDpgahtOkM7SnucuF101mnYff8LtjImZ//3pQltrHTRo++b1nWcVQcNb1rljuJ9Fgs9dzMP9DSnziYNcbAxUrcA0kTiDUOuOvxoVjvpGRkHKnEmXhZWQrhOP2sb15LpbDE6GBFs4xcIW8jat1cdem033wKBgQCnQjb2b88OgDssROf7GmXjUsSheeLshrxvf2dxiBomjtg0h9WKjP2ONoLKxwJNICBqvr1SbteIMQmw8/2QwCDvcx0JjNgkwuX6HabwmJ5qJFtn9wHB2gq1JZzoLvfwVr+uCVUF/EDciCqts08ynzYZoCbJ0LhTXdsQSDeGGRrIuwKBgQCcyIobRlhLRAXydXhCFsj4dCyDk7zMtyHzBKW93ROp23DYpCBUt4A7XxnRJ4OtX/jc3xjgLsIcOZlDxZMzBoMxXmSExu5FiNqLZ5ikPEm4hFHnlBJT6zkZYspze4aDgkVcMWNt3pYy1vKJbJtpCo+PQlP3ScnJxGIX72nT2l0KawKBgCrOioyV3xNiBEL3O7wLbIo6k7KUJFzOuwl6PPpUkATQSEthfGiiXv53uw+00UT19PX87S1cyvLDQiy0tW/HjGZcOtFH58W4z+0si55GIT0fIvm/wQZhDJ6CCt9tre0n9pTPNKB8iAkpHGsqWhmln839LBA4yAQmIDvRj8xVPoKjAoGBAP33PLwqJhVxgpG6uMhjmF3fEdTrrd40yEI0SnPHMRnQflbkXr+u6EOUWtVR4y5Buj0+ckNzIZXJ5k2GhpxT/vWmkEiOH4+WpTruQDuoa6S/nHP6QuP2AaGZyBDCfeTAWGp8i5HAsPSBdLyylgnmfkfQEVGZlEgUITjf31exJawu";
         ScanRequest scanRequest = new ScanRequest();
-        scanRequest.setPictureUrl("https://zing-finance.oss-cn-hangzhou.aliyuncs.com/%E8%BA%AB%E4%BB%BD%E8%AF%81%E6%AD%A3%E9%9D%A.jpg");
+        scanRequest.setPictureUrl("https://zing-finance.oss-cn-hangzhou.aliyuncs.com/%E8%BA%AB%E4%BB%BD%E8%AF%81%E6%AD%A3%E9%9D%A2.jpg");
         String md5 = "f5226bbba1eca51c03a56df636d44b1c";
         DefaultClient defaultClient = new DefaultClient("http://common-api.atliangtian.com/", appPrivateKey, md5, myPublicKey, "1");
         String testData = defaultClient.execute(scanRequest, "/open/api/ocr/v1/scanForIdCard");

src/test/java/verification/ShumaiMobileTest.java

@@ -19,7 +19,7 @@ public class ShumaiMobileTest {
         request.setMobile("18355551987");
         request.setName("计万成");
         request.setNumber("342921199302282819");
-        DefaultClient defaultClient = new DefaultClient("http://localhost:8080", appPrivateKey, md5, myPublicKey, "1");
+        DefaultClient defaultClient = new DefaultClient("http://common-api.atliangtian.com/", appPrivateKey, md5, myPublicKey, "1");
         String testData = defaultClient.execute(request, "/open/api/verification/v1/personalMobile");
         System.out.println(testData);
     }